Re: On non-Windows, hard depend on uselocale(3) - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: On non-Windows, hard depend on uselocale(3)
Date
Msg-id D3F61A59ARFJ.12K4NG1DEJ6DE@partin.io
Whole thread Raw
In response to Re: On non-Windows, hard depend on uselocale(3)  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Hey Thomas,

Thanks for picking this up. I think your patch looks really good. Are
you familiar with gcc's function poisoning?

    #include <stdio.h>
    #pragma GCC poison puts

    int main(){
    #pragma GCC bless begin puts
        puts("a");
    #pragma GCC bless end puts
    }

I wonder if we could use function poisoning to our advantage. For
instance in ecpg, it looks like you got all of the strtod() invocations
and replaced them with strtod_l(). Here is a patch with an example of
what I'm talking about.

--
Tristan Partin
Neon (https://neon.tech)

Attachment

pgsql-hackers by date:

Previous
From: "Tristan Partin"
Date:
Subject: Re: Subscription to Postgres Releases via ICS
Next
From: Sami Imseih
Date:
Subject: Re: Restart pg_usleep when interrupted