Re: Context diffs - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Context diffs
Date
Msg-id CA+hUKGJ=Df8jFJcNbhJfCfm_pxP0xVWw+UxM27GwT-4x1k5u=w@mail.gmail.com
Whole thread Raw
In response to Context diffs  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Context diffs  (Noah Misch <noah@leadboat.com>)
Re: Context diffs  (Andrew Dunstan <andrew@dunslane.net>)
Re: Context diffs  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Tue, Jan 5, 2021 at 8:07 AM Bruce Momjian <bruce@momjian.us> wrote:
> *  "git apply" and "git am" can't process context diffs (they throw an
>    error once a context-like section of the diff is hit; simple
>    adding/removing lines in a block works)
>
> *  the commit-fest doesn't recognized context diff attachments as
> patches:
>
>         https://commitfest.postgresql.org/31/2912/
>
> *  cfbot can't process file renames/add/delete from context diffs

For the record, cfbot just uses plain old GNU patch, because that
seems to accept nearly everything that anyone posts here (after a step
that tries to unpack tarballs etc).  Several people have suggested I
change it to use git apply instead (IIRC it works better for patches
containing binary files such as cryptographic keys?), but then it
wouldn't accept ye olde context diffs.



pgsql-hackers by date:

Previous
From: Victor Yegorov
Date:
Subject: Re: Deleting older versions in unique indexes to avoid page splits
Next
From: Thomas Munro
Date:
Subject: Re: Handing off SLRU fsyncs to the checkpointer