Re: Outdated comments about proc->sem in lwlock.c - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Outdated comments about proc->sem in lwlock.c
Date
Msg-id CA+hUKG+NaNp1+8709Afn8q2DHiFxxxY0549cBz4ySBpSwdCB6Q@mail.gmail.com
Whole thread Raw
Responses Re: Outdated comments about proc->sem in lwlock.c
List pgsql-hackers
On Wed, Mar 10, 2021 at 1:11 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> In passing I noticed that lwlock.c contains 3 comments about bogus
> wakeups due to sharing proc->sem with the heavyweight lock manager and
> ProcWaitForSignal.  Commit 6753333f55e (9.5) switched those things
> from proc->sem to proc->procLatch.  ProcArrayGroupClearXid() and
> TransactionGroupUpdateXidStatus() also use proc->sem though, and I
> haven't studied how those might overlap with with LWLockWait(), so I'm
> not sure what change to suggest.

Here's a patch to remove the misleading comments.

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Next
From: Justin Pryzby
Date:
Subject: Re: What to call an executor node which lazily caches tuples in a hash table? (GUC)