Re: Don't choke on files that are removed while pg_rewind runs. - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Don't choke on files that are removed while pg_rewind runs.
Date
Msg-id CA+fd4k4zqu8QxtaxLP3wJmY1ZVqpdWE_ZfSxuJa9__JKCB0y4w@mail.gmail.com
Whole thread Raw
In response to Re: Don't choke on files that are removed while pg_rewind runs.  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Don't choke on files that are removed while pg_rewind runs.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, 13 Jul 2020 at 15:34, Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 13 Jul 2020, at 08:10, Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> > Every other access to "res" in this loop is to res(i), which I believe is what
> > was intended here, too.  Currently, it will dumbly loop but skip *every* row if
> > the 2nd column (1: size) of the first row (0) is null.
>
> Yeah, I agree with that, seems like the call should've been PQgetisnull(res, i, 1);
> to match the loop.

+1

Regards,

-- 
Masahiko Sawada            http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: "movead.li@highgo.ca"
Date:
Subject: Re: POC and rebased patch for CSN based snapshots
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: max_slot_wal_keep_size and wal_keep_segments