Re: Don't choke on files that are removed while pg_rewind runs. - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Don't choke on files that are removed while pg_rewind runs.
Date
Msg-id A82A60E9-DF11-4A7D-8742-E99CD917AD87@yesql.se
Whole thread Raw
In response to Re: Don't choke on files that are removed while pg_rewind runs.  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: Don't choke on files that are removed while pg_rewind runs.  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
List pgsql-hackers
> On 13 Jul 2020, at 08:10, Justin Pryzby <pryzby@telsasoft.com> wrote:

> Every other access to "res" in this loop is to res(i), which I believe is what
> was intended here, too.  Currently, it will dumbly loop but skip *every* row if
> the 2nd column (1: size) of the first row (0) is null.

Yeah, I agree with that, seems like the call should've been PQgetisnull(res, i, 1);
to match the loop.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: possibility to read dumped table's name from file
Next
From: "movead.li@highgo.ca"
Date:
Subject: Re: POC and rebased patch for CSN based snapshots