Re: Don't choke on files that are removed while pg_rewind runs. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Don't choke on files that are removed while pg_rewind runs.
Date
Msg-id 20200713075629.GA10826@paquier.xyz
Whole thread Raw
In response to Re: Don't choke on files that are removed while pg_rewind runs.  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
Responses Re: Don't choke on files that are removed while pg_rewind runs.
List pgsql-hackers
On Mon, Jul 13, 2020 at 03:59:56PM +0900, Masahiko Sawada wrote:
> On Mon, 13 Jul 2020 at 15:34, Daniel Gustafsson <daniel@yesql.se> wrote:
>> Yeah, I agree with that, seems like the call should've been PQgetisnull(res, i, 1);
>> to match the loop.
>
> +1

Good catch, Justin.  There is a second thing here.  The second column
matches with the file size, so if its value is NULL then atol() would
just crash first.  I think that it would be more simple to first check
if the file size is NULL (isdir and link_target would be also NULL,
but just checking for the file size is fine), and then assign the
result values, like in the attached.  Any thoughts?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: OpenSSL 3.0.0 compatibility
Next
From: Daniel Gustafsson
Date:
Subject: Re: Don't choke on files that are removed while pg_rewind runs.