Re: [COMMITTERS] pgsql: Remove O(N^2) performance issue with multiple SAVEPOINTs. - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [COMMITTERS] pgsql: Remove O(N^2) performance issue with multiple SAVEPOINTs.
Date
Msg-id CA+U5nMLsw0FfGVAHzqa-e=L1XEy=_7tttXikLft1rb2wZ7Za+Q@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Remove O(N^2) performance issue with multiple SAVEPOINTs.  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
On Tue, Jul 19, 2011 at 9:24 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:

>> You might persuade me to do it another way, but I can't see how to
>> make that way work. Your case seems a stretch.
>
> You get coincidences with memory allocations surprisingly often, because
> things tend to get allocated and free'd in chunks of certain sizes. It's
> also pretty fragile in the face of future development. It's not hard to
> imagine someone adding code in lock.c to dereference the pointer.

Then I think we need a 4th phase (would actually happen first).

I will revoke and rework.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [v9.1] sepgsql - userspace access vector cache
Next
From: Yeb Havinga
Date:
Subject: Re: [v9.1] sepgsql - userspace access vector cache