Re: pgsql: Avoid tricky race condition recording XLOG_HINT - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Avoid tricky race condition recording XLOG_HINT
Date
Msg-id CA+U5nMJ306zQOHY0wvtj-33erGAhGR3Yo2fyPH4EHTZMaszyrg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Avoid tricky race condition recording XLOG_HINT  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Avoid tricky race condition recording XLOG_HINT  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 8 April 2013 15:29, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Simon Riggs <simon@2ndQuadrant.com> writes:
> Resulting code completely changes layout of XLOG_HINT WAL records, but
> this isn't even beta code, so this is a low impact change.

> src/include/catalog/catversion.h       |    2 +-

Just for the record, the right way to handle that kind of change is to
change XLOG_PAGE_MAGIC, not catversion.  A database's catalog version
might not be available to code that is inspecting WAL files and would
like to know what format it should expect.

Face>palm

I was so happy Andres had remembered to bump the catversion like I often do, it didn't occur to me it was the wrong one. My bad, sorry.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Avoid tricky race condition recording XLOG_HINT
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Avoid tricky race condition recording XLOG_HINT