Re: pgsql: Avoid tricky race condition recording XLOG_HINT - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Avoid tricky race condition recording XLOG_HINT
Date
Msg-id 13130.1365432470@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Avoid tricky race condition recording XLOG_HINT  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: pgsql: Avoid tricky race condition recording XLOG_HINT  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-committers
Simon Riggs <simon@2ndQuadrant.com> writes:
> On 8 April 2013 15:29, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Just for the record, the right way to handle that kind of change is to
>> change XLOG_PAGE_MAGIC, not catversion.  A database's catalog version
>> might not be available to code that is inspecting WAL files and would
>> like to know what format it should expect.

> I was so happy Andres had remembered to bump the catversion like I often
> do, it didn't occur to me it was the wrong one. My bad, sorry.

No problem.  XLOG_PAGE_MAGIC is already different from what it was in
9.2, so it's mostly academic whether or not we bump it again during
the devel cycle.

            regards, tom lane


pgsql-committers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: pgsql: Avoid tricky race condition recording XLOG_HINT
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Avoid tricky race condition recording XLOG_HINT