Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Avoid tricky race condition recording XLOG_HINT - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Avoid tricky race condition recording XLOG_HINT
Date
Msg-id 12578.1365431360@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Avoid tricky race condition recording XLOG_HINT  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: pgsql: Avoid tricky race condition recording XLOG_HINT  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-committers
Tree view 
Simon Riggs <simon@2ndQuadrant.com> writes:
> Resulting code completely changes layout of XLOG_HINT WAL records, but
> this isn't even beta code, so this is a low impact change.

> src/include/catalog/catversion.h       |    2 +-

Just for the record, the right way to handle that kind of change is to
change XLOG_PAGE_MAGIC, not catversion.  A database's catalog version
might not be available to code that is inspecting WAL files and would
like to know what format it should expect.

            regards, tom lane

pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix calculation of how many segments to retain for wal_keep_segm
Next
From: Simon Riggs
Date:
Subject: Re: pgsql: Avoid tricky race condition recording XLOG_HINT