Re: [HACKERS] Update comments in nodeModifyTable.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Update comments in nodeModifyTable.c
Date
Msg-id CA+TgmoaNWw623S5QB4RSLwhd8ByPLw4jhtpJjadkmKP+X6wtxQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Update comments in nodeModifyTable.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: [HACKERS] Update comments in nodeModifyTable.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
On Tue, Aug 1, 2017 at 12:31 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> Maybe I'm missing something, but I'm not sure that's a good idea because the
> change says like we might have 'wholerow' only for the FDW case, but that
> isn't correct because we would have 'wholerow' for a view as well. ISTM that
> views should be one of the typical cases, so I'd like to propose to modify
> the sentence starting with 'Typically' to something like this: "Typically,
> this will be a 'ctid' or 'wholerow' attribute, but in the case of a foreign
> data wrapper it might be a set of junk attributes sufficient to identify the
> remote row."  What do you think about that?

Works for me.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Partitioning vs ON CONFLICT
Next
From: Ildus K
Date:
Subject: Re: [HACKERS] Remove 1MB size limit in tsvector