Re: pg_basebackup: add test about zstd compress option - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_basebackup: add test about zstd compress option
Date
Msg-id CA+TgmoZgSqV0FkvHchZpajX1N1n=E92doV3kQST-miEzJNuDNA@mail.gmail.com
Whole thread Raw
In response to Re: pg_basebackup: add test about zstd compress option  (Ian Lawrence Barwick <barwick@gmail.com>)
Responses Re: pg_basebackup: add test about zstd compress option  (Ian Lawrence Barwick <barwick@gmail.com>)
Re: pg_basebackup: add test about zstd compress option  (Dong Wook Lee <sh95119@gmail.com>)
List pgsql-hackers
On Fri, Dec 2, 2022 at 11:29 PM Ian Lawrence Barwick <barwick@gmail.com> wrote:
> Though on reflection maybe it's overkill and the existing tests
> suffice. Anyway leaving the patch here in the interests of pushing
> this forward in some direction.

Do you think that there is a scenario where 008_untar.pl and
009_extract.pl pass but this test fails, alerting us to a problem that
would otherwise have gone undetected? If so, what is that scenario?

The only thing that I can think of would be if $decompress_program
--test were failing, but actually trying to decompress succeeded. I
would be inclined to dismiss that particular scenario as not important
enough to be worth the additional CPU cycles.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: ANY_VALUE aggregate
Next
From: Robert Haas
Date:
Subject: Re: pg_dump: Remove "blob" terminology