Re: pg_basebackup: add test about zstd compress option - Mailing list pgsql-hackers

From Dong Wook Lee
Subject Re: pg_basebackup: add test about zstd compress option
Date
Msg-id CAAcByaJTcGM9X4k8G0G0-b3OSXqdUFskwciVtyGkC1Rad8MCyQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_basebackup: add test about zstd compress option  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
> The only thing that I can think of would be if $decompress_program
> --test were failing, but actually trying to decompress succeeded. I
> would be inclined to dismiss that particular scenario as not important
> enough to be worth the additional CPU cycles.

When I wrote this test, it was just to increase coverage for pg_basebackup.
As I checked again, it already does that in the pg_verifybackup
008_untar.pl, 009_extrack.pl test you mentioned.
Therefore, I agree with your opinion.

---
Regards,
DongWook Lee.



pgsql-hackers by date:

Previous
From: "Takamichi Osumi (Fujitsu)"
Date:
Subject: RE: Time delayed LR (WAS Re: logical replication restrictions)
Next
From: Pavel Borisov
Date:
Subject: Re: [PATCH] Check snapshot argument of index_beginscan and family