Postgres Pro
Downloads
Home   >   mailing lists

Re: Department of Redundancy Department: makeNode(FuncCall) division - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Department of Redundancy Department: makeNode(FuncCall) division
Date
Msg-id CA+TgmoZWBfYdNmm4zUz9esjTu-e1FgNJffc5sFYER1zr-OaRZA@mail.gmail.com
Whole thread Raw
In response to Re: Department of Redundancy Department: makeNode(FuncCall) division  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Department of Redundancy Department: makeNode(FuncCall) division
List pgsql-hackers
Tree view 
On Fri, Jun 28, 2013 at 10:31 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> David Fetter <david@fetter.org> writes:
>> Please find attached the latest patch.
>
> I remain of the opinion that this is simply a bad idea.  It is unlike
> our habits for constructing other types of nodes, and makes it harder
> not easier to find all the places that need to be updated when adding
> another field to FuncCall.

I think it's a nice code cleanup.  I don't understand your objection.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls
Next
From: Alvaro Herrera
Date:
Subject: Re: changeset generation v5-01 - Patches & git tree