Re: Department of Redundancy Department: makeNode(FuncCall) division - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Department of Redundancy Department: makeNode(FuncCall) division
Date
Msg-id 51CDC7C3.7080204@gmx.net
Whole thread Raw
In response to Re: Department of Redundancy Department: makeNode(FuncCall) division  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Department of Redundancy Department: makeNode(FuncCall) division
List pgsql-hackers
On 6/28/13 11:30 AM, Robert Haas wrote:
> On Fri, Jun 28, 2013 at 10:31 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> David Fetter <david@fetter.org> writes:
>>> Please find attached the latest patch.
>>
>> I remain of the opinion that this is simply a bad idea.  It is unlike
>> our habits for constructing other types of nodes, and makes it harder
>> not easier to find all the places that need to be updated when adding
>> another field to FuncCall.
> 
> I think it's a nice code cleanup.  I don't understand your objection.

Yeah, I was reading the patch thinking, yes, finally someone cleans that up.




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls
Next
From: Peter Eisentraut
Date:
Subject: Re: Documentation/help for materialized and recursive views