Re: Department of Redundancy Department: makeNode(FuncCall) division - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Department of Redundancy Department: makeNode(FuncCall) division
Date
Msg-id 8057.1372429876@sss.pgh.pa.us
Whole thread Raw
In response to Re: Department of Redundancy Department: makeNode(FuncCall) division  (David Fetter <david@fetter.org>)
Responses Re: Department of Redundancy Department: makeNode(FuncCall) division  (David Fetter <david@fetter.org>)
Re: Department of Redundancy Department: makeNode(FuncCall) division  (Noah Misch <noah@leadboat.com>)
Re: Department of Redundancy Department: makeNode(FuncCall) division  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
David Fetter <david@fetter.org> writes:
> Please find attached the latest patch.

I remain of the opinion that this is simply a bad idea.  It is unlike
our habits for constructing other types of nodes, and makes it harder
not easier to find all the places that need to be updated when adding
another field to FuncCall.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: changeset generation v5-01 - Patches & git tree
Next
From: David Fetter
Date:
Subject: Re: Department of Redundancy Department: makeNode(FuncCall) division