Re: MSVC pl-perl error message is not verbose enough - Mailing list pgsql-hackers

From Robert Haas
Subject Re: MSVC pl-perl error message is not verbose enough
Date
Msg-id CA+TgmoYp=2Ah1HwJ=GpGsxFPvGwvb6GDZnMeeu6NUK_XT9qYgA@mail.gmail.com
Whole thread Raw
In response to Re: MSVC pl-perl error message is not verbose enough  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: MSVC pl-perl error message is not verbose enough  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Tue, Jul 26, 2016 at 9:44 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Jul 27, 2016 at 12:41 AM, John Harvey
> <john.harvey@crunchydata.com> wrote:
>> Because of this, I've submitted a small patch which fixes the verbosity of
>> the error message to actually explain what's missing.  I hope that this
>> patch will be considered for the community, and it would be nice if it was
>> back-patched.
>
> Improving this error message a bit looks like a good idea to me.
> Looking at the code to figure out what build.pl is looking for is a
> bit a pain for users just willing to compile the code, so if we can
> avoid such lookups with a cheap way, let's do it.
>
> Instead of your patch, I'd suggest saving $solution->{options}->{perl}
> . '\lib\CORE\perl*.lib' in a variable and then raise an error based on
> that. See attached.

Did you add this to the next CommitFest?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: PostgreSQL 10 kick-off
Next
From: Robert Haas
Date:
Subject: Re: Constraint merge and not valid status