Re: MSVC pl-perl error message is not verbose enough - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: MSVC pl-perl error message is not verbose enough
Date
Msg-id CAB7nPqQJ_x=HtVRx7xFLb20y7HVJaSoywBVuHCkXtXc1xOGMaQ@mail.gmail.com
Whole thread Raw
In response to MSVC pl-perl error message is not verbose enough  (John Harvey <john.harvey@crunchydata.com>)
Responses Re: MSVC pl-perl error message is not verbose enough  (John Harvey <john.harvey@crunchydata.com>)
Re: MSVC pl-perl error message is not verbose enough  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Wed, Jul 27, 2016 at 12:41 AM, John Harvey
<john.harvey@crunchydata.com> wrote:
> Because of this, I've submitted a small patch which fixes the verbosity of
> the error message to actually explain what's missing.  I hope that this
> patch will be considered for the community, and it would be nice if it was
> back-patched.

Improving this error message a bit looks like a good idea to me.
Looking at the code to figure out what build.pl is looking for is a
bit a pain for users just willing to compile the code, so if we can
avoid such lookups with a cheap way, let's do it.

Instead of your patch, I'd suggest saving $solution->{options}->{perl}
. '\lib\CORE\perl*.lib' in a variable and then raise an error based on
that. See attached.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PoC: Make it possible to disallow WHERE-less UPDATE and DELETE
Next
From: Tom Lane
Date:
Subject: Re: No longer possible to query catalogs for index capabilities?