Re: [bug fix] Memory leak in dblink - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [bug fix] Memory leak in dblink
Date
Msg-id CA+TgmoYgyWceLzUnk4+YKC3xgxtkKbp836SmOnBVPxi0MeKoyg@mail.gmail.com
Whole thread Raw
In response to Re: [bug fix] Memory leak in dblink  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [bug fix] Memory leak in dblink  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, Jun 10, 2014 at 12:27 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> Is there a need to free memory context in PG_CATCH()?
> In error path the memory due to this temporary context will get
> freed as it will delete the transaction context and this
> temporary context will definitely be in the hierarchy of it, so
> it should also get deleted.  I think such handling can be
> useful incase we use PG_CATCH() to suppress the error.

Using PG_CATCH() to suppress an error is pretty much categorically unsafe.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: why postgresql define NTUP_PER_BUCKET as 10, not other numbers smaller
Next
From: Tom Lane
Date:
Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels