On Wed, May 23, 2018 at 10:48 PM, Anthony Emengo <aemengo@pivotal.io> wrote:
Hey all,
Attached is a rather large patch that attempts to introduce the Pytest test runner and Grappah test matcher into our code base. The patch replaces all of the previous python unit tests from the previous design. This is a follow-up from our previous proof of concept and discussion around the idiosyncrasies of our existing test suite.
We are motivated to submit this change for the following reasons:
1. Having a highly customized test suite increases the learning curve towards contributing to the code base. Pytest is a mature stable python test framework that outside developers are more likely to be familiar with.
2. Pytest supports a lot of the features that we've built for our use-cases - out of the box, and with extensive documentation on the matter.
3. The lack of ability to run tests individually has become a pain point. Especially when it comes to debugging long running feature tests.
Test can be ran with the following command:
yarn test:unit
Please let us know what you think and if there are any issues!
Note: The feature tests are not yet completed. We expect our CI to fail as a result of this patch. We will complete this step soon in a follow-up patch!
Please don't forget to update the README and top level Makefile as well! I'll probably have to tweak my Windows CI jobs, but the Linux/Mac ones all use the Makefile (which is also hard-coded into my fingers)!
