Re: [PATCH] pgAgent segfault - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [PATCH] pgAgent segfault
Date
Msg-id CA+OCxoxMW=NwVVSdcquXZTquxdep1cHi4DGVap=xTeTtMJXkEA@mail.gmail.com
Whole thread Raw
In response to [PATCH] pgAgent segfault  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Mon, Jun 11, 2018 at 5:25 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave,

While debugging the issue reported by Rob, I found one segfault.
Please find the attached patch to find that fix along with another one.

1. Connection object was being accessed, which was already released.

2. Changed the logic for checking the connection object existence.

We're using "if (!ms_primaryCon)", which should convert the logic as boolean operator explicitly, which we defined for the 'DBconn' class.

I suspect some compilers (specifically windows one) may not behave that way, and instead of using the boolean operator, it checks for the pointer is NULL or not.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi




--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAgent commit: 1. Connection object was being accessed,which was alre
Next
From: Joao De Almeida Pereira
Date:
Subject: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutesto execute