[PATCH] pgAgent segfault - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject [PATCH] pgAgent segfault
Date
Msg-id CAG7mmoy7ruK=HZGOt5GTFsuSF5e4+zHnagU0hJfuMUhqjZs=mw@mail.gmail.com
Whole thread Raw
Responses Re: [PATCH] pgAgent segfault  (Dave Page <dave.page@enterprisedb.com>)
List pgadmin-hackers
Hi Dave,

While debugging the issue reported by Rob, I found one segfault.
Please find the attached patch to find that fix along with another one.

1. Connection object was being accessed, which was already released.

2. Changed the logic for checking the connection object existence.

We're using "if (!ms_primaryCon)", which should convert the logic as boolean operator explicitly, which we defined for the 'DBconn' class.

I suspect some compilers (specifically windows one) may not behave that way, and instead of using the boolean operator, it checks for the pointer is NULL or not.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: PGAgent 4.0 error feedback
Next
From: Ashesh Vashi
Date:
Subject: Re: PGAgent 4.0 error feedback