pgAgent commit: 1. Connection object was being accessed,which was alre - Mailing list pgadmin-hackers

From Dave Page
Subject pgAgent commit: 1. Connection object was being accessed,which was alre
Date
Msg-id E1fSPSO-0007Kh-DP@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
1. Connection object was being accessed, which was already released.

2. Changed the logic for checking the connection object existence.

We're using "if (!ms_primaryCon)", which should convert the logic as boolean operator explicitly, which we defined for
the'DBconn' class. 

I suspect some compilers (specifically windows one) may not behave that way, and instead of using the boolean operator,
itchecks for the pointer is NULL or not. 

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=1c583df4bbf0a3f15a5f919096057cca70da1237
Author: Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Modified Files
--------------
connection.cpp | 2 +-
pgAgent.cpp    | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][RM#3404] Graphical explain plan do not display textunder the node
Next
From: Dave Page
Date:
Subject: Re: [PATCH] pgAgent segfault