Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin Event Trigger Compatibility - Mailing list pgadmin-hackers

From Dave Page
Subject Re: pgAdmin Event Trigger Compatibility
Date
Msg-id CA+OCxox6WCy71Fstmn6XRgCAyHM02bXwdbGfnwghZCQ-XtJrvw@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin Event Trigger Compatibility  (Dinesh Kumar <dinesh.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Thu, Jul 4, 2013 at 3:10 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:
Hi Dave,

Thanks for your time.

Please find the attached new patch for the same. As per my testing on windows/linux, it's working fine.

Kindly let me know if you face any issues and suggestions.


OK, it builds fine on Mac for me now. Some initial feedback:

- Instead of "DDL_COMMAND_START", we should use "DDL COMMAND START". The same applies to similar cases.

- Can we combine the Enable and Enable Status options into one set of radio buttons, e.g. Enabled (which should be the default), Replica, Always and Disabled?

- Please fix the sizing of the box around the aforementioned radio buttons. See the screen shots for an example of what I mean. It should match the "Fires" box on dlgTrigger.

Thanks. 

Akshay; can you do a code review please?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Dinesh Kumar
Date:
Subject: Re: pgAdmin Event Trigger Compatibility
Next
From: Dave Page
Date:
Subject: Re: PATCH: Handle the cross type of debugging (context & in-context) on same function at the same time