Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin Event Trigger Compatibility - Mailing list pgadmin-hackers

From Dinesh Kumar
Subject Re: pgAdmin Event Trigger Compatibility
Date
Msg-id CAKWsr7iAif00Z=hTaURoLQ_Fezt=kkvNCgxwS4EMkK7SzoRtxQ@mail.gmail.com
Whole thread Raw
In response to pgAdmin Event Trigger Compatibility  (Dinesh Kumar <dinesh.kumar@enterprisedb.com>)
Responses Re: pgAdmin Event Trigger Compatibility  (Dinesh Kumar <dinesh.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view
On Mon, Jul 8, 2013 at 6:17 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jul 4, 2013 at 3:10 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:
Hi Dave,

Thanks for your time.

Please find the attached new patch for the same. As per my testing on windows/linux, it's working fine.

Kindly let me know if you face any issues and suggestions.


OK, it builds fine on Mac for me now. Some initial feedback:

- Instead of "DDL_COMMAND_START", we should use "DDL COMMAND START". The same applies to similar cases.

- Can we combine the Enable and Enable Status options into one set of radio buttons, e.g. Enabled (which should be the default), Replica, Always and Disabled?

- Please fix the sizing of the box around the aforementioned radio buttons. See the screen shots for an example of what I mean. It should match the "Fires" box on dlgTrigger.


Thanks Dave,

I will update this thread with the suggested changes.

Dinesh

-- 
Dinesh Kumar
Software Engineer

Ph: +918087463317
Skype ID: dinesh.kumar432
www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Patch for pgAdmin crash, while creating procedure.
Next
From: Dave Page
Date:
Subject: Re: pgAdmin Event Trigger Compatibility