Re: createuser doesn't tell default settings for some options - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: createuser doesn't tell default settings for some options
Date
Msg-id B6D1C802-DFD1-4E90-A5FC-DD860280A233@yesql.se
Whole thread Raw
In response to Re: createuser doesn't tell default settings for some options  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
> On 10 Aug 2022, at 10:28, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> On 10 Aug 2022, at 08:12, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
>>
>> (I suppose this is a pg15 issue)
>>
>> createuser --help shows the following help text.
>>
>>> --bypassrls               role can bypass row-level security (RLS) policy
>>> --no-bypassrls            role cannot bypass row-level security (RLS) policy
>>> --replication             role can initiate replication
>>> --no-replication          role cannot initiate replication
>>
>> For other options the text tells which one is the default, which I
>> think the two options also should have the same.
>
> Agreed.  For --no-replication the docs in createuser.sgml should fixed to
> include a "This is the default" sentence like the others have as well.

>> The ternary options are checked against decimal 0, but it should use
>> TRI_DEFAULT instead. (attached third)
>
> Agreed, nice catch.

Attached is my proposal for this, combining your 0001 and 0003 patches with
some docs and test fixups to match.

--
Daniel Gustafsson        https://vmware.com/


Attachment

pgsql-hackers by date:

Previous
From: Dmitry Koval
Date:
Subject: Re: Operation log for major operations
Next
From: Alvaro Herrera
Date:
Subject: Re: Catalog_xmin is not advanced when a logical slot is lost