Re: Catalog_xmin is not advanced when a logical slot is lost - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Catalog_xmin is not advanced when a logical slot is lost
Date
Msg-id 20221121141956.utp5labspysmf5id@alvherre.pgsql
Whole thread Raw
In response to Re: Catalog_xmin is not advanced when a logical slot is lost  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Responses Re: Catalog_xmin is not advanced when a logical slot is lost
List pgsql-hackers
On 2022-Nov-21, Ashutosh Bapat wrote:

> Maybe. In that case pg_get_replication_slots() should be changed. We
> should use the same criteria to decide whether a slot is invalidated
> or not at all the places.

Right.

> I am a fan of stricter, all-assumption-covering conditions. In case we
> don't want to check restart_lsn, an Assert might be useful to validate
> our assumption.

Agreed.  I'll throw in an assert.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: createuser doesn't tell default settings for some options
Next
From: Alexander Pyhalov
Date:
Subject: Re: CREATE INDEX CONCURRENTLY on partitioned index