Re: Catalog_xmin is not advanced when a logical slot is lost - Mailing list pgsql-hackers

From sirisha chamarthi
Subject Re: Catalog_xmin is not advanced when a logical slot is lost
Date
Msg-id CAKrAKeWR0dgdwZpnFupyJdB9u5d9kfJXrs_5wAwDRG41Grd4_Q@mail.gmail.com
Whole thread Raw
In response to Re: Catalog_xmin is not advanced when a logical slot is lost  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Catalog_xmin is not advanced when a logical slot is lost
List pgsql-hackers
Thanks Alvaro,  Ashutosh  for your comments.

On Mon, Nov 21, 2022 at 6:20 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
On 2022-Nov-21, Ashutosh Bapat wrote:

> Maybe. In that case pg_get_replication_slots() should be changed. We
> should use the same criteria to decide whether a slot is invalidated
> or not at all the places.

Right.
 
Agreed.
 

> I am a fan of stricter, all-assumption-covering conditions. In case we
> don't want to check restart_lsn, an Assert might be useful to validate
> our assumption.

Agreed.  I'll throw in an assert.
 
Changed this in the patch to throw an assert. 


--
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
Attachment

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Damage control for planner's get_actual_variable_endpoint() runaway
Next
From: Ilya Gladyshev
Date:
Subject: postgres_fdw binary protocol support