On Fri, Jan 21, 2011 at 12:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>>> - Why not initialize logid and logseg like so?:
>>>
>>> int logid = startptr.xlogid;
>>> int logseg = startptr.xrecoff / XLogSegSize;
>>>
>>> Then use those in your elog? Seems cleaner to me.
>
>> Hmm. Yes. Agreed.
>
> Marginal complaint here: int is the wrong type, I'm pretty sure.
And, we should use XLByteToPrevSeg here instead of just =, I think.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
