Re: Include WAL in base backup - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Include WAL in base backup
Date
Msg-id 14124.1295537305@sss.pgh.pa.us
Whole thread Raw
In response to Re: Include WAL in base backup  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Include WAL in base backup  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
>> - Why not initialize logid and logseg like so?:
>> 
>> � � � �int logid = startptr.xlogid;
>> � � � �int logseg = startptr.xrecoff / XLogSegSize;
>> 
>> �Then use those in your elog? �Seems cleaner to me.

> Hmm. Yes. Agreed.

Marginal complaint here: int is the wrong type, I'm pretty sure.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Moving test_fsync to /contrib?
Next
From: Florian Pflug
Date:
Subject: Re: pg_dump directory archive format / parallel pg_dump