Re: Make archiver check for SIGHUP more often? - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Make archiver check for SIGHUP more often?
Date
Msg-id AANLkTim2XXaF9yw_6oReSNoniBg-rvrkmIppTq12SdE_@mail.gmail.com
Whole thread Raw
In response to Make archiver check for SIGHUP more often?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, May 11, 2010 at 10:13 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> There's a complaint over here
> http://archives.postgresql.org/pgsql-general/2010-05/msg00365.php
> about the archiver process not being very swift to adopt a new
> value of archive_command.  This is because it only reacts to SIGHUP
> once per outer loop, ie, only after completing an archiving cycle.
> This is unhelpful in the example case, since the point of changing
> the command is to get it to finish archiving faster.
>
> How do people feel about adding
>
>                /* Check for config update */
>                if (got_SIGHUP)
>                {
>                        got_SIGHUP = false;
>                        ProcessConfigFile(PGC_SIGHUP);
>                }
>
> to the inner loop in pgarch_ArchiverCopyLoop?  This would allow
> a new archive_command value to be adopted immediately for the next
> copy attempt.  (Hm, I guess we'd need to recheck XLogArchiveCommandSet
> as well...)

Yeah, go for it.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: [GENERAL] Archiver not picking up changes to archive_command
Next
From: Takahiro Itagaki
Date:
Subject: Re: [BUGS] "SET search_path" clause ignored during function creation