Re: contrib/pg_stat_statements 1226 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: contrib/pg_stat_statements 1226
Date
Msg-id 9092.1231013665@sss.pgh.pa.us
Whole thread Raw
In response to contrib/pg_stat_statements 1226  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: contrib/pg_stat_statements 1226  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> "Alex Hunsaker" <badalex@gmail.com> wrote:
>> How about just pg_stat_statements.track ?

> I renamed the variables to:
>     - pg_stat_statements.limit
>     - pg_stat_statements.track
>     - pg_stat_statements.saved_file

Hmm, this has got a problem:

regression=# show pg_stat_statements.limit ;
ERROR:  syntax error at or near "limit"
LINE 1: show pg_stat_statements.limit ;                               ^

LIMIT is a reserved word ...

I thought max_statements was fine, but if people think that's too long
I guess we could go with just "max".

I'm not enamored of "saved_file" either, it seems like the wrong
part of speech somehow.  Maybe "save_in_file"?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Custom PGC_POSTMASTER GUC variables ... feasible?
Next
From: Magnus Hagander
Date:
Subject: Re: reloptions and toast tables