contrib/pg_stat_statements 1226 - Mailing list pgsql-hackers

From ITAGAKI Takahiro
Subject contrib/pg_stat_statements 1226
Date
Msg-id 20081226145707.AF00.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: contrib/pg_stat_statements 1212  ("Alex Hunsaker" <badalex@gmail.com>)
Responses Re: contrib/pg_stat_statements 1226  ("Alex Hunsaker" <badalex@gmail.com>)
Re: contrib/pg_stat_statements 1226  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: contrib/pg_stat_statements 1226  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Here is an updated version of contrib/pg_stat_statements patch.

"Alex Hunsaker" <badalex@gmail.com> wrote:

> >> I think the explain_analyze_format guc is a clever way of getting
> >> around the explain analyze verbose you proposed earlier.  But I dont
> >> see any doc updates for it.

Documentation is added.

> How about just pg_stat_statements.track ?

I renamed the variables to:
    - pg_stat_statements.limit
    - pg_stat_statements.track
    - pg_stat_statements.saved_file

I also modified assign_custom_variable_classes()
to accept '_' as a prefix character, not only 0-9A-Za-z.

> I do like the consistency of having the custom gucs be the same as the
> module name, easy to grep or google for.

Should I also rename variables used in auto_explain module?
It uses 'explain.*' now.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: NOTIFY extra parameter
Next
From: "Koichi Suzuki"
Date:
Subject: Re: V2 of PITR performance improvement for 8.4