Re: HEAPDEBUGALL is broken - Mailing list pgsql-hackers

From Alexander Lakhin
Subject Re: HEAPDEBUGALL is broken
Date
Msg-id 8936216c-3492-3f6e-634b-d638fddc5f91@gmail.com
Whole thread Raw
In response to Re: HEAPDEBUGALL is broken  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: HEAPDEBUGALL is broken  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
21.04.2020 21:01, Peter Eisentraut wrote:
> On 2020-04-19 22:00, Alexander Lakhin wrote:
>> To the point, I've tried to use HAVE_ALLOCINFO on master today and it
>> failed too:
>
> Do you have a proposed patch?
>
As this is broken at least since the invention of the generational
allocator (2017-11-23, a4ccc1ce), I believe than no one uses this (and
slab is broken too). Nonetheless, HAVE_ALLOCINFO in aset.c is still
working, so it could be leaved alone, though the output too chatty for
general use (`make check` produces postmaster log of size 3.8GB). I
think someone would still need to insert some extra conditions to use
that or find another way to debug memory allocations.

So I would just remove this debug macro. The proposed patch is attached.

Best regards,
Alexander

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: WAL usage calculation patch
Next
From: Dilip Kumar
Date:
Subject: Re: fixing old_snapshot_threshold's time->xid mapping