Re: Macros for time magic values - Mailing list pgsql-hackers

From Dimitri Fontaine
Subject Re: Macros for time magic values
Date
Msg-id 87bp1e2fbx.fsf@hi-media-techno.com
Whole thread Raw
In response to Re: Macros for time magic values  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Macros for time magic values
List pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes:

> On Sat, 2011-03-12 at 22:29 +0200, Peter Eisentraut wrote:
>> On fre, 2011-03-11 at 12:50 -0500, Bruce Momjian wrote:
>> > It has bothered me that many of our time routines use special magic
>> > constants for time values, e.g. 24, 12, 60, etc.
>> > 
>> > The attached patch changes these magic constants to macros to clarify
>> > the code.  I would like to apply this for 9.1 as a cleanup.
>> 
>> I think it's much clearer with the plain numbers.
>
> Yeh. It's not like the values 24, 12 or 60 were going to change.

Would it help moving toward Leap Second support, and is this something
we want to have?
 http://en.wikipedia.org/wiki/Leap_second

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: PostgreSQL 8.4 support on Windows 2008 R2
Next
From: Tom Lane
Date:
Subject: Re: Patch to git_changelog for release note creation