Re: Macros for time magic values - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Macros for time magic values
Date
Msg-id 1300090979.1790.7554.camel@ebony
Whole thread Raw
In response to Re: Macros for time magic values  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Macros for time magic values
Re: Macros for time magic values
Re: Macros for time magic values
List pgsql-hackers
On Sat, 2011-03-12 at 22:29 +0200, Peter Eisentraut wrote:
> On fre, 2011-03-11 at 12:50 -0500, Bruce Momjian wrote:
> > It has bothered me that many of our time routines use special magic
> > constants for time values, e.g. 24, 12, 60, etc.
> > 
> > The attached patch changes these magic constants to macros to clarify
> > the code.  I would like to apply this for 9.1 as a cleanup.
> 
> I think it's much clearer with the plain numbers.

Yeh. It's not like the values 24, 12 or 60 were going to change.

-- Simon Riggs           http://www.2ndQuadrant.com/books/PostgreSQL Development, 24x7 Support, Training and Services



pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: Better estimates of index correlation
Next
From: Simon Riggs
Date:
Subject: Re: Shared invalidation cache messages for temporary tables