Re: ISM shared memory on solaris - Mailing list pgsql-bugs

Bruce Momjian <pgman@candle.pha.pa.us> writes:

> ! #if defined(sun) && defined(__sparc__)
>       /* use intimate shared memory on SPARC Solaris */
>       memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
>   #else

I think this is going in the wrong direction.  Why isn't the code just

#if defined(SHM_SHARE_MMU)
    /* use intimate shared memory on Solaris */
    memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
#else

If the symbol is available I think we probably want to use it.  It is an
O/S issue, not a hardware issue, and so the test on __sparc__ seems
quite wrongheaded ...

            regards, tom lane