Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format - Mailing list pgsql-bugs

From Peter Eisentraut
Subject Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format
Date
Msg-id 84fe26d6-5a46-2064-0cce-f0067f299517@2ndquadrant.com
Whole thread Raw
In response to Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-bugs
On 8/10/17 04:21, Masahiko Sawada wrote:
>> The Commit message format is incorrectly documented. The `flags` field[0] is
>> missing. I ran into this while creating a parser for the messages in
>> Golang.
>>
>> [0]
>> https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
>>
> 
> Thank you for reporting. Yeah, it's not used actually for now but
> should be documented. Attached patch.

Committed, thanks!

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [BUGS] Crash report for some ICU-52 (debian8) COLLATE andwork_mem values
Next
From: Tom Lane
Date:
Subject: Re: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values