Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format - Mailing list pgsql-bugs

On Wed, Aug 9, 2017 at 2:08 PM,  <kyle@kyleconroy.com> wrote:
> The following bug has been logged on the website:
>
> Bug reference:      14775
> Logged by:          Kyle Conroy
> Email address:      kyle@kyleconroy.com
> PostgreSQL version: 10beta2
> Operating system:   macOS
> Description:
>
> The Commit message format is incorrectly documented. The `flags` field[0] is
> missing. I ran into this while creating a parser for the messages in
> Golang.
>
> [0]
> https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
>

Thank you for reporting. Yeah, it's not used actually for now but
should be documented. Attached patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs