Re: StringInfo misc. issues - Mailing list pgsql-hackers

From Tom Lane
Subject Re: StringInfo misc. issues
Date
Msg-id 784.1188400489@sss.pgh.pa.us
Whole thread Raw
In response to StringInfo misc. issues  (NikhilS <nikkhils@gmail.com>)
Responses Re: StringInfo misc. issues  (NikhilS <nikkhils@gmail.com>)
List pgsql-hackers
NikhilS <nikkhils@gmail.com> writes:
> The attached patch should fix this.

And break other things, no doubt.  needed = 0 is a perfectly valid
edge case and mustn't be rejected here.  (In fact, I doubt you'd
even get through the regression tests with this patch ... how much
did you test it?)

The real problem with what you describe is that you should have used
makeStringInfo().

> I also found the absence of a function like resetStringInfo() a bit
> puzzling.

CVS HEAD is way ahead of you.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: StringInfo misc. issues
Next
From: Hans-Juergen Schoenig
Date:
Subject: correct behavior of ANALYZE ...