Re: pg_combinebackup: correct code comment. - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pg_combinebackup: correct code comment.
Date
Msg-id 713CFD44-BE8E-4CA7-81FE-F91BE48E5874@yesql.se
Whole thread Raw
In response to pg_combinebackup: correct code comment.  (Amul Sul <sulamul@gmail.com>)
Responses Re: pg_combinebackup: correct code comment.
Re: pg_combinebackup: correct code comment.
List pgsql-hackers
> On 15 Apr 2025, at 06:22, Amul Sul <sulamul@gmail.com> wrote:

> Attached is a patch that corrects the code comment for
> process_directory_recursively() in pg_combinebackup, where the comment
> incorrectly refers to "output_directory" instead of the intended
> "input_directory".

Agreed.  The second paragraph in the comment also seem a bit odd, how about the
below while we are there fixing things?

- * If processing is a user-defined tablespace, the tsoid should be the OID
+ * If processing a user-defined tablespace, the tsoid should be the OID

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Umar Hayat
Date:
Subject: Re: New committer: Jacob Champion
Next
From: Fujii Masao
Date:
Subject: Re: use correct variable in error message in _allocAH function (pg_backup_archiver.c)