Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_combinebackup: correct code comment. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_combinebackup: correct code comment.
Date
Msg-id CA+TgmobUvsWkKB0SzX6FRtPeNHh0hAJtzHnYMhgbb1+NBF6+0A@mail.gmail.com
Whole thread Raw
In response to Re: pg_combinebackup: correct code comment.  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: pg_combinebackup: correct code comment.
List pgsql-hackers
Tree view 
On Tue, Apr 15, 2025 at 3:46 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> > On 15 Apr 2025, at 06:22, Amul Sul <sulamul@gmail.com> wrote:
> > Attached is a patch that corrects the code comment for
> > process_directory_recursively() in pg_combinebackup, where the comment
> > incorrectly refers to "output_directory" instead of the intended
> > "input_directory".
>
> Agreed.  The second paragraph in the comment also seem a bit odd, how about the
> below while we are there fixing things?
>
> - * If processing is a user-defined tablespace, the tsoid should be the OID
> + * If processing a user-defined tablespace, the tsoid should be the OID

Yeah, I agree with both of these changes. Feel free to commit, unless
you want me to do it.

--
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Next
From: torikoshia
Date:
Subject: Align memory context level numbering in pg_log_backend_memory_contexts()