Re: pg_combinebackup: correct code comment. - Mailing list pgsql-hackers

On Tue, Apr 15, 2025 at 1:16 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 15 Apr 2025, at 06:22, Amul Sul <sulamul@gmail.com> wrote:
>
> > Attached is a patch that corrects the code comment for
> > process_directory_recursively() in pg_combinebackup, where the comment
> > incorrectly refers to "output_directory" instead of the intended
> > "input_directory".
>
> Agreed.  The second paragraph in the comment also seem a bit odd, how about the
> below while we are there fixing things?
>
> - * If processing is a user-defined tablespace, the tsoid should be the OID
> + * If processing a user-defined tablespace, the tsoid should be the OID
>

+1

Regards,
Amul