Re: Add const to values and nulls arguments - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Add const to values and nulls arguments
Date
Msg-id 69593f41-546f-4e45-bdd7-8f8a8d61386c@eisentraut.org
Whole thread Raw
In response to Re: Add const to values and nulls arguments  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: Add const to values and nulls arguments
List pgsql-hackers
On 06.10.23 16:51, Aleksander Alekseev wrote:
>> There are a lot of Datum *values, bool *nulls argument pairs that should
>> really be const.  The 0001 patch makes those changes.  Some of these
>> hunks depend on each other.
>>
>> The 0002 patch, which I'm not proposing to commit at this time, makes
>> similar changes but in a way that breaks the table and index AM APIs.
>> So I'm just including that here in case anyone wonders, why didn't you
>> touch those.  And also maybe if we ever change that API incompatibly we
>> could throw this one in then.
> 
> 0001 looks good to me and passes the tests in several environments,
> not surprisingly. Let's merge it.

done




pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Crash in add_paths_to_append_rel
Next
From: Nishant Sharma
Date:
Subject: Re: [Code Cleanup] : Small code cleanup in twophase.sql