Re: [Code Cleanup] : Small code cleanup in twophase.sql - Mailing list pgsql-hackers

From Nishant Sharma
Subject Re: [Code Cleanup] : Small code cleanup in twophase.sql
Date
Msg-id CADrsxdaZ84tJ9hu9SSgR-PMDk7X+4LpLV0aQfxpZhVaR0V36_w@mail.gmail.com
Whole thread Raw
In response to [Code Cleanup] : Small code cleanup in twophase.sql  (Nishant Sharma <nishant.sharma@enterprisedb.com>)
List pgsql-hackers
Hi,

Any taker or rejector for above? -- It's a very small 'good to have' change patch for cleanup.

Thanks,
Nishant (EDB).

On Tue, Sep 26, 2023 at 6:31 PM Nishant Sharma <nishant.sharma@enterprisedb.com> wrote:
Hi,


PFA small code cleanup in twophase.sql. Which contains a drop table
statement for 'test_prepared_savepoint'. Which, to me, appears to be
missing in the cleanup section of that file.

To support it I have below points:-

1) Grepping this table 'test_prepared_savepoint' shows occurrences
only in twophase.out & twophase.sql files. This means that table is
local to that sql test file and not used in any other test file.

2) I don't see any comment on why this was not added in the cleanup
section of twophase.sql, but drop for other two test tables are done.

3) I ran "make check-world" with the patch and I don't see any failures.

Kindly correct, if I missed anything.


Regards,
Nishant (EDB).

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Add const to values and nulls arguments
Next
From: Michael Paquier
Date:
Subject: Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag