Re: Add const to values and nulls arguments - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Add const to values and nulls arguments
Date
Msg-id CAJ7c6TPaf-uoiTnHeYfubBVQmybpxgotLAyqiK=O7E64PhHd9Q@mail.gmail.com
Whole thread Raw
In response to Add const to values and nulls arguments  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Add const to values and nulls arguments
List pgsql-hackers
Hi,

> There are a lot of Datum *values, bool *nulls argument pairs that should
> really be const.  The 0001 patch makes those changes.  Some of these
> hunks depend on each other.
>
> The 0002 patch, which I'm not proposing to commit at this time, makes
> similar changes but in a way that breaks the table and index AM APIs.
> So I'm just including that here in case anyone wonders, why didn't you
> touch those.  And also maybe if we ever change that API incompatibly we
> could throw this one in then.

0001 looks good to me and passes the tests in several environments,
not surprisingly. Let's merge it.

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Two Window aggregate node for logically same over clause
Next
From: Justin Pryzby
Date:
Subject: Re: pg16: invalid page/page verification failed