Re: pgsql: Remove BufFile's isTemp flag. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove BufFile's isTemp flag.
Date
Msg-id 6917.1511138238@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Remove BufFile's isTemp flag.  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> On 2017-11-19 17:00:36 -0500, Tom Lane wrote:
>> No, but if you're concerned about it, we could maintain API compatibility
>> for extensions with something like
>> #define BufFileCreateTemp(interXact) BufFileCreate(interXact)

> I don't really see a point in doing this renaming in the first
> place. It's not like the Temp suffix has become inaccurate. I'd perhaps
> not add it in the green field, but I don't see a need to change an
> existing function name. If anything it seems confusing because you'd
> miss something when trivially searching the history / comparing
> branches.

Well, that's a fair point about history, but the reason I no longer
want the Temp suffix is that it implies that there's such a thing as
a non-temp BufFile.  I think that's misleading if we've cut off any
vestige of support for it.

Anybody else have an opinion?
        regards, tom lane


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows