Re: Out-of-memory error reports in libpq - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Out-of-memory error reports in libpq
Date
Msg-id 680764.1627530009@sss.pgh.pa.us
Whole thread Raw
In response to Re: Out-of-memory error reports in libpq  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Out-of-memory error reports in libpq  (Peter Smith <smithpb2250@gmail.com>)
Re: Out-of-memory error reports in libpq  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Ranier Vilela <ranier.vf@gmail.com> writes:
> IMO, I think that "char *msg" is unnecessary, isn't it?

> + if (!PQExpBufferBroken(errorMessage))
> + res->errMsg = pqResultStrdup(res, errorMessage->data);
>   else
> - res->errMsg = NULL;
> + res->errMsg = libpq_gettext("out of memory\n");

Please read the comment.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Gurjeet Singh
Date:
Subject: Re: Slightly improve initdb --sync-only option's help message
Next
From: Yugo NAGATA
Date:
Subject: Re: pgbench bug candidate: negative "initial connection time"