Re: Slightly improve initdb --sync-only option's help message - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: Slightly improve initdb --sync-only option's help message
Date
Msg-id CABwTF4USUH0gW_jvOhktLX1JEs57RJ69sBKhBTWnkX2X+youBQ@mail.gmail.com
Whole thread Raw
In response to Re: Slightly improve initdb --sync-only option's help message  ("Bossart, Nathan" <bossartn@amazon.com>)
List pgsql-hackers
On Mon, Jul 26, 2021 at 11:05 AM Bossart, Nathan <bossartn@amazon.com> wrote:
> Here are my suggestions in patch form.

+    printf(_("  -S, --sync-only           safely write all database
files to disk and exit\n"));

Not your patch's fault, but the word "write" does not seem to convey
the true intent of the option, because generally a "write" operation
is still limited to dirtying the OS buffers, and does not guarantee
sync-to-disk.

It'd be better if the help message said, either "flush all database
files to disk and exit",or "sync all database files to disk and exit".

Best regards,
--
Gurjeet Singh http://gurjeet.singh.im/



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Next
From: Tom Lane
Date:
Subject: Re: Out-of-memory error reports in libpq