Re: Less than ideal error reporting in pg_stat_statements - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: Less than ideal error reporting in pg_stat_statements
Date
Msg-id 56030EE0.4030008@BlueTreble.com
Whole thread Raw
In response to Re: Less than ideal error reporting in pg_stat_statements  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
List pgsql-hackers
On 9/22/15 6:27 PM, Jim Nasby wrote:
>> + ereport(LOG,
>> +              (errcode(ERRCODE_OUT_OF_MEMORY),
>> +               errmsg("out of memory attempting to pg_stat_statement
>> file"),
>> +               errdetail("file \"%s\": size %lld", PGSS_TEXT_FILE,
>> stat.st_size)));
>>
>> Uh, what?
>
> Oops. I'll fix that and address David's concern tomorrow.

New patch attached. I stripped the size reporting out and simplified the
conditionals a bit as well.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com

Attachment

pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Less than ideal error reporting in pg_stat_statements
Next
From: Kam Lasater
Date:
Subject: Re: No Issue Tracker - Say it Ain't So!